headwirecom / jsonforms-react-spectrum-renderers

Other
8 stars 4 forks source link

Improve color scheme selector #70

Closed uudens closed 3 years ago

uudens commented 3 years ago

Replace some custom elements in the Example files with React Spectrum elements in order to get color scheme selector working properly

Screenshot 2020-12-10 at 17 25 51-min Screenshot 2020-12-10 at 17 18 21-min

mburri commented 3 years ago

Looks very nice! but there is an issue with the example picker that is out of sync with the shown example, if the theme changes.

How to reproduce:

Behavior: the "numbers" example is still selected, but a different example is shown.

image

uudens commented 3 years ago

@mburri thank you for the feedback and for checking it out! My bad, I've pushed a commit with a fix 🙂

mburri commented 3 years ago

On a closer look, I noticed that new code was not formatted with prettier and the license header was missing in the new file theme.switcher.tsx - I allowed myself to fix it.

I think the prettier formatting is not documented and it would be a good idea to add a commit hook that asserts the prettier formatting - see #71

@uudens feel free to merge this PR.

uudens commented 3 years ago

@mburri thanks!