headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.48k stars 159 forks source link

ResolveUrl() don't work with tag <base href="..."> #132

Closed MashinaMashina closed 3 years ago

MashinaMashina commented 3 years ago

ResolveUrl() don't work with tag <base href="...">

If page contains tag <base href="...">, resolving must be relatively href attribute, now is relatively browser url.

headzoo commented 3 years ago

Looks good. Thanks for the PR.

MashinaMashina commented 3 years ago

@headzoo when I can view my fix after go get github.com/headzoo/surf or go get gopkg.in/headzoo/surf.v1 ?

I need this fix in my project, but I dont want to edit local package

headzoo commented 3 years ago

I pushed tag v1.0.1. Give go get a try now using that version.