search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.48k stars 159 forks source link

No support for form input types checkbox, radio or select multi #43

Closed jtwatson closed 3 years ago

jtwatson commented 7 years ago

There is a serious issue when handling forms that have checkbox's, radio buttons or select multiple input types. If you submit a form that has checkbox's, they will all be checked when submitted regardless of there state as downloaded. Forms with radio buttons will have the last button selected regardless of original state. Disabled fields are submitted, etc.

I will be submitting a PR shortly to implement robust support for Checkboxes, Radio buttons and Select multiple input elements. It also handles disabled fields properly.

jtwatson commented 7 years ago

When do you think we can get a review of the PR for this issue?

lielran commented 7 years ago

I think that inputs can be found only by name(and not id,class,css selector)

lxt2 commented 7 years ago

@jtwatson ok to close this now?

jtwatson commented 7 years ago

I think so. @lielran left a comment that I haven't had time to look into yet.