search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.49k stars 160 forks source link

Make attribute for allowing insecure http requests #47

Closed jmitre closed 7 years ago

jmitre commented 7 years ago

Added attribute MakeInsecureRequests to allow the browser to make insecure requests. And also modified the buildClient() method of Browser to make a transporter configured to skip verification when MakeInsecureRequests is set to true.

jtwatson commented 7 years ago

I don't think this is the right approach. There already exists a function for setting the transport:

func (bow *Browser) SetTransport(rt http.RoundTripper)

your new attribute MakeInsecureRequests would be completely overridden by this existing function.

It is much more idiomatic to just use the SetTransport() function to accomplish what you want.

jmitre commented 7 years ago

Thank you. I didn't realize that function exists because I didn't see it in the documentation. Using the SetTransport method is a better way to accomplish this.