search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.49k stars 160 forks source link

Add support for browser.SetTimeout #52

Closed nxadm closed 7 years ago

nxadm commented 7 years ago

Hi,

Surf is a very nice library. For my use case it's missing a way to add a Timeout when opening a connection. The underlying http.client does support a Timeout (https://golang.org/pkg/net/http/#Client), so I went ahead and added to the browser. It works as expected in my code:

browser := surf.NewBrowser()
browser.SetTimeout(10 * time.Second)

If you consider merging this PR, let me know if something needs to be changed.

Regards,

C.

nxadm commented 7 years ago

Hi,

I read this in the Contribution.md file:

"Pull Requests: Code changes are made to the dev branch. Once a milestone has been reached the branch will be merged in with master, and a new version tag created. Do not make your changes against the master branch, or they will more than likely be ignored."

However, there is no dev branch. Do you prefer me to resend the PR applied to the v2 branch?

Thank you,

C.

headzoo commented 7 years ago

I'll have to change the contribution file. I think we recently decided to scrap the idea of submitting PR against the dev branch.