search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.49k stars 160 forks source link

Add support for appengine #61

Closed utahta closed 7 years ago

utahta commented 7 years ago

Hi.

I want to use this great library with appengine.

But appengine does not allow import syscall package, so always build fails like below

2017/06/28 11:03:03 go-app-builder: Failed parsing input: parser: bad import "syscall" in github.com/headzoo/surf/agent/agent.go from GOPATH

I fixed a this problem using build tag. (it might be workaround, but I think works well) refs #49

lxt2 commented 7 years ago

We've really got to do something about that agent package. Having to add explicit support for every platform is significantly gross.

lxt2 commented 7 years ago

Until we've got a better approach for the agent package, I'm happy to merge this if @headzoo is.

headzoo commented 7 years ago

@lxt2 Looks good to me.