search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.48k stars 159 forks source link

Extend osName and osVersion to work on various systems #7

Closed tatsushid closed 9 years ago

tatsushid commented 9 years ago

Another implementation to fix #4. This separates osName and osVersion into each system's own files and doesn't have uname command dependency.

xiaods commented 9 years ago

cool, support it.

peterhellberg commented 9 years ago

Looks good to me :)

mholt commented 9 years ago

Builds on Mac! Looks great, @tatsushid - thanks for doing it.

Running off this fork for now :smile:

s3ththompson commented 9 years ago

Any idea when this might be merged in? headzoo/surf is completely broken on OSX without this patch.

headzoo commented 9 years ago

@s3ththompson I went ahead and merged, although I can't test the code myself. I'll have to take your word for it that it works.

mholt commented 9 years ago

Awesome, thanks @headzoo! (And you can take my word too. Works here.)

s3ththompson commented 9 years ago

Thanks so much. Fixed.