search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.48k stars 159 forks source link

Fix: case where form input does not contain value attribute. #8

Closed kgv closed 9 years ago

kgv commented 9 years ago

Before fix: field will not be added if form input does not contain value attribute. After fix: field will be added if form input does not contain value attribute.

mholt commented 9 years ago

+1 I was just about to make this same change. As far as I know right now, it's impossible to fill out fields that don't already have a value. Would love to see this merged in :+1:

girishso commented 9 years ago

+1

mholt commented 9 years ago

@kgv A few commits have been made to master since this PR was opened -- I bet if you rebased this would be more likely to be merged in sooner.

headzoo commented 9 years ago

@mholt You're right, so I think I'm going to close this pull request for now.