search

headzoo / surf

Stateful programmatic web browsing in Go.
MIT License
1.49k stars 160 forks source link

Update browser.go #94

Closed k3a closed 6 years ago

k3a commented 6 years ago

Use the actual timeout for http client.

There should also be a default timeout of 30 minutes for example so that every request finishes at some point eventually (see https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779)

lxt2 commented 6 years ago

This is addressed in #107, which sets the timeout in SetTimeout. I agree a default timeout would make sense.