search

heal-research / HeuristicLab

HeuristicLab - An environment for heuristic and evolutionary optimization
https://dev.heuristiclab.com
GNU General Public License v3.0
34 stars 16 forks source link

Provide ability to reuse views if the content is already displayed #1372

Closed HeuristicLab-Trac-Bot closed 13 years ago

HeuristicLab-Trac-Bot commented 13 years ago

Issue migrated from trac ticket # 1372

milestone: HeuristicLab 3.3.3 | component: MainForm.WindowsForms | priority: medium | resolution: done

2011-01-11 10:48:52: @mkommend created the issue

The mainform should provide a method overload of ShowContent which specifies if an existing view displaying the same content should be reused.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-11 11:59:13: @mkommend changed status from new to accepted

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-11 12:01:45: @mkommend changed status from accepted to reviewing

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-11 12:01:45: @mkommend changed owner from mkommend to abeham

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-11 12:01:45: @mkommend commented

Implemented ShowContent method in MainForm which reuses existing views and adapted the ClipBoard with r5270.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-11 16:15:48: @mkommend commented

Corrected check in setter of ViewType in the ViewHost with r5278.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-12 10:39:01: @abeham changed owner from abeham to swagner

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-12 10:39:01: @abeham changed title from Reuse views if the content is already displayed to Provide ability to reuse views if the content is already displayed

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-12 10:39:01: @abeham commented

I reviewed r5270.

I made some attempts in thinking about a ShowContent<T, U> where T : class,IContent where U : class,IContentView. However that's not so easy in the case no existing view can be found. Since U can be an interface, one would be required to check for a view for the content's type which typeof(U) is also assignable from.

Anyway since the view is returned to the caller, the check can be made there if that was the required view.

I'm forwarding this to swagner for reviewing the change r5278 and the change to the Clipboard.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-15 03:38:23: @s-wagner changed owner from swagner to mkommend

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-15 03:38:23: @s-wagner commented

I think line 113 of ViewHost in r5278 should be

if (value !# null && value= typeof(ViewHost))

and not

if (value !# null && value.GetType()= typeof(ViewHost))

Apart from that I agree with the changes of r5270 and r5278. Thanks.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-18 09:49:43: @mkommend commented

Replying to [comment:5 swagner]:

I think line 113 of ViewHost in r5278 should be

if (value !# null && value= typeof(ViewHost))

and not

if (value !# null && value.GetType()= typeof(ViewHost))

Apart from that I agree with the changes of r5270 and r5278. Thanks.

The check was corrected as suggested in r5318.

HeuristicLab-Trac-Bot commented 13 years ago

2011-01-19 13:34:14: @mkommend changed owner from mkommend to swagner

HeuristicLab-Trac-Bot commented 13 years ago

2011-02-04 03:17:28: @s-wagner changed status from reviewing to readytorelease

HeuristicLab-Trac-Bot commented 13 years ago

2011-02-04 03:17:28: @s-wagner changed owner from swagner to mkommend

HeuristicLab-Trac-Bot commented 13 years ago

2011-02-05 19:04:24: @mkommend changed status from readytorelease to closed

HeuristicLab-Trac-Bot commented 13 years ago

2011-02-05 19:04:24: @mkommend removed resolution