heal-research / HeuristicLab

HeuristicLab - An environment for heuristic and evolutionary optimization
https://dev.heuristiclab.com
GNU General Public License v3.0
39 stars 16 forks source link

Improve the Vehicle Routing implementation #1953

Closed HeuristicLab-Trac-Bot closed 11 years ago

HeuristicLab-Trac-Bot commented 12 years ago

Issue migrated from trac ticket # 1953

milestone: HeuristicLab 3.3.8 | component: Problems.VehicleRouting | priority: medium | resolution: done

2012-09-14 10:01:41: svonolfe created the issue


Some issues and feature requests have been discovered in the VRP 3.4 implementation.

svonolfe:

  • the distance matrix is reset when starting an algorithm
  • some instances of the LiLim benchmark instances are not named correctly
  • vehicles are not assigned correctly when a solution includes empty trips

mkommend:

  • the view should be improved to show the parameters of the problem
  • the design of the instance interpreters could be improved to avoid code duplication
HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:01:51: svonolfe changed status from new to accepted

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:03:18: svonolfe commented


Improved the design of the interpreters so code duplication is avoided in r8649

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:04:42: svonolfe commented


Fixed naming of the LiLim instances in r8650

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:06:09: svonolfe commented


Imrpoved VRP problem instance view in r8651

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:07:25: svonolfe commented


The distance matrix was reset when starting an algorithm the first time (r8652)

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:08:44: svonolfe edited the issue description

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:09:49: svonolfe commented


vehicles were not assigned correctly when a solution includes empty trips (r8653)

HeuristicLab-Trac-Bot commented 12 years ago

2012-09-14 10:10:15: svonolfe edited the issue description

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-16 13:30:16: svonolfe changed milestone from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.8

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-16 13:30:16: svonolfe changed owner from svonolfe to @mkommend

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-16 13:30:16: svonolfe changed status from accepted to reviewing

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-19 14:16:54: @mkommend commented


Reviewing comments:

  • Use explicit conversions (casts) in Interpreters instead of the as operator.
  • IVRPDataInterpreter.GetDataType is not used anywhere.
  • Remove the local field distanceMatrix from the VRPProblemInstance and refactor the GetDistance method.

I would suggest that you fix parameters which are determined by the loaded problem instance, e.g. vehicles, depots.

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-19 14:16:54: @mkommend changed owner from @mkommend to svonolfe

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-19 14:16:54: @mkommend changed status from reviewing to assigned

HeuristicLab-Trac-Bot commented 12 years ago

2012-11-19 16:30:01: @mkommend commented


r8922: Refactored GetDistance method in VRPProblemInstace.

HeuristicLab-Trac-Bot commented 11 years ago

2012-12-06 16:18:42: svonolfe commented


r9010: used explicit conversions in Interpreters and removed the unused method IVRPDataInterpreter.GetDataType

HeuristicLab-Trac-Bot commented 11 years ago

2012-12-06 16:19:12: svonolfe changed status from assigned to reviewing

HeuristicLab-Trac-Bot commented 11 years ago

2012-12-06 16:19:12: svonolfe changed owner from svonolfe to @mkommend

HeuristicLab-Trac-Bot commented 11 years ago

2012-12-06 16:46:59: @mkommend changed status from reviewing to readytorelease

HeuristicLab-Trac-Bot commented 11 years ago

2012-12-06 16:46:59: @mkommend changed owner from @mkommend to svonolfe

HeuristicLab-Trac-Bot commented 11 years ago

2013-05-10 01:59:26: @s-wagner changed status from readytorelease to closed

HeuristicLab-Trac-Bot commented 11 years ago

2013-05-10 01:59:26: @s-wagner removed resolution