Closed HeuristicLab-Trac-Bot closed 9 years ago
r9116: branch project
Problems.DataAnalysis.Views
r9117: branch project
Algorithms.DataAnalysis.Views
- added
OneRClassificationModelView
- added
ClassificationSolutionComparisonView
- added several calculators (
ConfusionMatrixCalculator
,FOneScoreCalculator
,MatthewsCorrelationCoefficientCalculator
)- fixed bug in
OneR
- added
StorableClass
andItem
attribute to several classes
OneR
now handles missing values separately- adapted
OneRClassificationModelView
to show the class of missing values- with a double-click on the row header in
ClassificationSolutionComparisonView
the selected solution opens in a new view- put a try catch block around linear discriminant analysis solution (it is only shown, if it doesn't throw an exception)
ZeroR may not be a good model in the
ClassificationSolutionComparisonView
, becauseMatthewsCorrelationCoefficientCalculator
will always calculateNaN
and F1 score will also beNaN
if the negative class is chosen by ZeroR.
Can we queue this for the next release version?
Discussed in architects meeting, should be integrated into the trunk.
r10553: Updated classification model comparison branch with trunk changes.
r10556: Updated classification model comparison branch with trunk changes (remaining changes).
r10560: Fixed bugs in classification solution comparison view.
r10570: Added missing value handling in new implementation of OneR.
Reviewed r10560 changes are OK:
Made a more detailed review of the source code. Notes from the overall source code review:
Adapt to work with current trunk version (export button).Exception occurs when running a linear discriminant analysis model (works for the trunk)cannot reproduceMove OneR and ZeroR out of the Algorithms.DataAnalysis.Linear folder.doneOneR and ZeroR should not be available in the "New Item" dialog.doneExecutionTime for OneR should not be produced as a result.I guess this is ok.The file OneRTest.cs can be deleted?No, the OneRTest.cs file is the new implementation by mkommend. The file OneR.cs should be deleted
Not yet ready for release
Sorry
r13082: merged changesets r10553 to r13081 (only on HeuristicLab.Problems.DataAnalysis.Views) from trunk to branch r13083: merged changesets r10551 to r13082 (only on HeuristicLab.Problems.DataAnalysis) from trunk to branch r13084: merged changesets r10551 to r13083 (only on HeuristicLab.Algorithms.DataAnalysis.Views) from trunk to branch r13085: merged changesets r10551 to r13084 (only on HeuristicLab.Algorithms.DataAnalysis) from trunk to branch
r13086: made compatibility changes necessary because of trunk developments (compile fail)
- deleted obsolete version of OneR algorithm (also does perform worse than mkommend's implementation in my tests)
- reused the ConstantRegressionModel as ConstantClassificationModel (OK?)
- fixed a few strings here and there
r13090: moved OneR and ZeroR out of the folder for linear models, renamed OneRTest -> OneR
r13091: minor changes while reviewing
Reviewed changes in
- HeuristicLab.Problems.DataAnalysis (online calculators of F1-score and Matthews correlation have been added)
- HeuristicLab.Algorithms.DataAnalysis (ZeroR and OneR algorithms have been added)
- HeuristicLab.Problems.DataAnalysis.Views (only ClassificationSolutionComparisonView has been added)
- HeuristicLab.Algorithms.DataAnalysis.Views (only the OneRClassificationModelView has been added)
TODO:
don't calculate F1 score for multi-class problems- terminate branch
more detailed review of online calculators and algorithmsadd F1 score and Matthew's correlation to classification results collectionmark ConstantRegressionModel obsolete and create new class: ConstantModel
Issue migrated from trac ticket # 1998
milestone: HeuristicLab 3.3.13 | component: Algorithms.DataAnalysis | priority: high | resolution: done
2012-12-17 17:09:17: @t-h-e created the issue