search

heal-research / HeuristicLab

HeuristicLab - An environment for heuristic and evolutionary optimization
https://dev.heuristiclab.com
GNU General Public License v3.0
34 stars 16 forks source link

Views should support displaying help texts #2100

Closed HeuristicLab-Trac-Bot closed 10 years ago

HeuristicLab-Trac-Bot commented 11 years ago

Issue migrated from trac ticket # 2100

milestone: HeuristicLab 3.3.9 | component: MainForm.WindowsForms | priority: medium | resolution: done

2013-08-29 11:41:05: @Shabbafru created the issue

HeuristicLab-Trac-Bot commented 11 years ago

2013-08-29 11:41:12: @Shabbafru changed status from new to accepted

HeuristicLab-Trac-Bot commented 11 years ago

2013-08-29 11:44:06: @Shabbafru commented

r9915 added a help button to View which opens and displays help texts if a help resource path is specified in the view attribute

HeuristicLab-Trac-Bot commented 11 years ago

2013-08-29 12:05:11: @Shabbafru commented

r9916 added loading of txt files

HeuristicLab-Trac-Bot commented 11 years ago

2013-08-29 12:05:33: @Shabbafru changed status from accepted to reviewing

HeuristicLab-Trac-Bot commented 11 years ago

2013-08-29 12:05:33: @Shabbafru changed owner from @Shabbafru to @mkommend

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 12:26:05: @Shabbafru changed status from reviewing to assigned

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 12:26:05: @Shabbafru changed owner from @mkommend to @Shabbafru

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 12:26:05: @Shabbafru commented

r9920 moved help system from View to ViewHost

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 13:38:42: @Shabbafru commented

r9921 improved handling of position of help label

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 13:39:33: @Shabbafru changed status from assigned to reviewing

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-02 13:39:33: @Shabbafru changed owner from @Shabbafru to @mkommend

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-03 13:58:48: @mkommend changed status from reviewing to assigned

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-03 13:58:48: @mkommend changed owner from @mkommend to @Shabbafru

HeuristicLab-Trac-Bot commented 11 years ago

2013-09-03 13:58:48: @mkommend commented

Code review comments:

InfoBox.cs

  • Remove unnecessary default ctor.
  • Remove properties for caption, embedded resource and parentView. It should be sufficient to store them in private fields.
  • Use accept button property of the form instead of an additional event handler (okButton_Click)
  • Use the form load (or a better suited event override) for the loading of embedded resources and access the defining assembly by the parent property.
HeuristicLab-Trac-Bot commented 11 years ago

2013-09-04 10:49:58: @Shabbafru commented

r9935 implemented review comments

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-13 13:24:46: @Shabbafru changed status from assigned to reviewing

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-13 13:24:46: @Shabbafru changed owner from @Shabbafru to @gkronber

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-16 19:35:35: @gkronber changed status from reviewing to readytorelease

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-16 19:35:35: @gkronber changed owner from @gkronber to @Shabbafru

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-16 19:35:35: @gkronber commented

Reviewed r9935. The review comments have been implemented. Also reviewed r9915 to r9916 and r9920 to r9921.

However, I couldn't test the functionality as the trunk does not contain views that provide a help resource?

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-17 10:01:31: @Shabbafru commented

Thanks! Yes that's right, the only views that use this functionality at the moment are the Chart Analysis view and the Statistical Testing view from the StatisticalTesting branch.

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-17 10:06:02: @Shabbafru changed status from readytorelease to closed

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-17 10:06:02: @Shabbafru removed resolution

HeuristicLab-Trac-Bot commented 10 years ago

2013-09-17 10:06:02: @Shabbafru commented

r9977 merged r9915-r9916, r9920-r9921, r9935 into stable branch