Closed HeuristicLab-Trac-Bot closed 8 years ago
Thanks for code reorganization. I'm going to create tickets for your remaining remarks from the review.
Replying to [comment:22 mkommend]:
Reviewed the SymbolicExpressionTreeProblem and HL.Problems.GP and the according views and unit test for sample creation.
Comments:
- Odd source code organization (cloning and persistence in a region at the EOF)
Fixed with r13269.
- BasicSymbolicRegression
- Recreates constants every time the problem is changed => not reproducible
- Couldn't the solution be transformed to a standard data analysis tree (simplify, optimize?
Might be fixed in the future (-> separate tickets #2515, #2517)
- Why are the boolean problems restricted (number of bits) and why is this done in the evaluation function?
In the case of the even-parity problem the restriction stems from the fact that only digits are used as terminal symbols and there are only 10 digits. Would be easy to extend this.
In the case of the mux-problem I don't remember the exact reason but I believe this is an artifact from an earlier implementation where only digits and characters were used as terminal symbols. In any case the limit of 37 bits input is rather large and would mean that a single evaluation would have to iterate over 2^37^ different input cases... I'm going to create a ticket for this (#2516).
Overall pretty cool and easy to implement problems. I am especially impressed on how easy tree evaluation can be performed for the boolean and regression problems.
Issue migrated from trac ticket # 2472
milestone: HeuristicLab 3.3.13 | component: Problems.GeneticProgramming | priority: medium | resolution: done
2015-08-27 07:01:05: @gkronber created the issue