Closed HeuristicLab-Trac-Bot closed 7 years ago
r14790: added problem instance descriptors for miba friction datasets
r14791: fixed training / test partitions and allowed input variables
r14853: set factor variables as allowed for miba friction benchmark problem instances
Reviewed MibaFriction regression instances.
The only comment I have is that the code in the InstanceProvider.GetDataDescriptors does not make sense to me. Why is the zip file queried and then the data descriptor matched with the filename and if that succeeds the resourcename set? When i am adding a new DataDescriptor I know the corresponding resource name and can set it directly in the class. I only have to check if the resource name is present in the archive.
Replying to [comment:8 mkommend]:
The only comment I have is that the code in the InstanceProvider.GetDataDescriptors does not make sense to me. Why is the zip file queried and then the data descriptor matched with the filename and if that succeeds the resourcename set? When i am adding a new DataDescriptor I know the corresponding resource name and can set it directly in the class. I only have to check if the resource name is present in the archive.
Code stems from RegressionRealWorldInstanceProvider.cs. Will check.
r15016: simplified code for regression instance providers which load data from a ZIP file
Merge after #2650 and #2660
Issue migrated from trac ticket # 2757
milestone: HeuristicLab 3.3.15 | component: Problems.DataAnalysis | priority: medium | resolution: done
2017-03-29 10:58:10: @gkronber created the issue