heal-research / SimSharp

Sim# is a .NET port of SimPy, process-based discrete event simulation framework
MIT License
126 stars 30 forks source link

Improvements #19

Closed sjefvanleeuwen closed 3 years ago

abeham commented 5 years ago

Thank you for the pull request! I can understand your motivation, however I don't think it considers an improvement. First, the ISimulate interface should belong to the samples project and should probably be called ISample or ISimulationSample. It does not add value to SimSharp itself and no type implements it there. Simulate() also has about the same meaning as Run() for Simulation. I think the type is confusing if we add it to Sim# itself. Second, regarding the change to RunSamples() when testing or implementing new features I just comment those samples that I do not include or test a feature with to run just the ones I need. This is more cumbersome if done in such an automated way. I also think reflection code is not as simple to understand for people not as acquainted with the .NET framework (though I believe RunAllSamples is not the code people are interested in really).

Nevertheless, I greatly appreciate that you took the time to look at Sim# and think of potential enhancements!