healenium / healenium-backend

Client for Healenium
Apache License 2.0
23 stars 26 forks source link

[Need support]: disable uploading metrics to Amazon S3 #59

Open wakatuts opened 2 years ago

wakatuts commented 2 years ago

Describe the problem

I agree that uploading the healing results should help the team in figuring out the best healing algorithm, but I think it's a bit of a stretch that we gather sensitive information (url, project repository name, absolute locator path) without any consent from the users. I hope we could have a way to disable this by default and just encourage the users to participate in improving the healing algorithm by enabling it via configuration.

Healenium Web version

v.3.2.5

Healenium Backend version

v.3.2.3

Selenium version

4.1.4

Platform

Java 1.8

Logs appeared during using Healenium

n/a

Additional context

No response

ElenaStepuro commented 2 years ago

Hello @wakatuts all sensitive info stores only on your machine where tests are running and not going anywhere. Access to this info depends on your project access configs

wakatuts commented 2 years ago

apologies for not being totally familiar yet with AWS lambda, but why do we need to have the java class below if we only store the information to machine where tests are running? https://github.com/healenium/healenium-backend/blob/master/src/main/java/com/epam/healenium/rest/AmazonRestService.java

ElenaStepuro commented 2 years ago

@wakatuts we count the number of successful and failed healings to make the algorithm more clear. No worries, we don't store any data except this. Aws repository is private (because of our credentials) but if necessary we could send the code which data is stored

wakatuts commented 2 years ago

hi @ElenaStepuro would it be possible if the team will add a property in healenium.properties such that when it is set to false, the system won't upload it to amazon s3?