search

health-data-science-OR / coding-for-ml

Learning materials for Coding for Machine Learning and Data Science
https://www.pythonhealthdatascience.com
MIT License
15 stars 4 forks source link

Issue on page /content/01_algorithms/04_exercises/02_basic_oop.ipynb #29

Closed SubaruSpirit closed 2 years ago

SubaruSpirit commented 2 years ago

This problem exists in both Exercises and Solutions.

Currently in Exercise 2: the 2nd Hint suggests Patient.Age can be a random number or a constant.

But this is not in the right context for this exercise, instead this hint should be in Exercise 3 where the user needs to define the age for the Patient class, and it perhaps should also be Patient.age.

In Exercise 3, it should also be made clear that the goal of the function is to add new patients with random generated numbers, not predefined values (for example, manually create 5 entries of Patient with user defined unique ID and age).

TomMonks commented 2 years ago

fixed in dev reference to patient.age removed from ex2 additional instructions and example of generating random ages added to ex3

TomMonks commented 2 years ago

now live at pythonhealthdatascience.com