Sliding Window Range in Exercise 1 autoregression_keras_part1_SOLUTIONS.ipynb

health-data-science-OR / forecasting

Forecasting materials for Making a difference with health data

MIT License

6 stars 3 forks source link

Sliding Window Range in Exercise 1 autoregression_keras_part1_SOLUTIONS.ipynb #30

Closed ploginovic closed 2 months ago

ploginovic commented 8 months ago

https://github.com/health-data-science-OR/forecasting/blob/master/06_neural_networks/feedforward/keras/autoregression_keras_part1_SOLUTIONS.ipynb

Exercise 1 sliding_window( ) (line 967) does not include the last slice. This is because range is defined as "for i in range(0, len(train) - window_size - horizon)" without +1.

TomMonks commented 2 months ago

Thanks @ploginovic . Fixed in upcoming 2025 release and acknowledgement added.