search

healthify / fake_idp

Fake IdP service for testing SAML
https://rubygems.org/gems/fake_idp
MIT License
15 stars 8 forks source link

Update activesupport dependency #44

Closed AlecRust closed 3 years ago

AlecRust commented 3 years ago

It's great that fake_idp is now published to RubyGems (maybe README should be updated with this) but sadly I still have to load this gem from GitHub to pin it to a version before you added a dependency on Active Support 5.

Our app is running Rails 6.0.3.5 which depends on activesupport (= 6.0.3.5), but this gem depends on activesupport (~> 5.2.4.3). Any chance you could update your Active Support dependency?

tylerwillingham commented 3 years ago

@AlecRust sorry for the delayed response. We'll work on prioritizing a change to prevent that activesupport from being a blocker

tylerwillingham commented 3 years ago

Pull request #47 will track the evolution of this change

AlecRust commented 3 years ago

Thanks! Any chance you could publish a new release with this change?

tylerwillingham commented 3 years ago

@AlecRust 1.0.2 was pushed by @k-peek on 4/16 to RubyGems 😄

AlecRust commented 3 years ago

Cool. Now it's just ruby-saml ~> 1.11.0 causing a problem 😄

tylerwillingham commented 3 years ago

@AlecRust I took a quick glance at the CHANGELOG for ruby-saml and I think we should be fine to lock to a version <= 1.12.0 (it doesn't look like they always respect semver, but I'm open to being wrong). Our team has a lot of things in flight at the moment so if you'd like to make a PR allowing for a higher limit for that dependency I'd be happy to give it a review and own the release over the next 1-2 weeks.

AlecRust commented 3 years ago

Cheers done https://github.com/healthify/fake_idp/pull/48.

tylerwillingham commented 3 years ago

@AlecRust 1.0.3 has been pushed to rubygems! Thanks for your contribution!

AlecRust commented 3 years ago

Being that specific wasn't suitable for long: https://github.com/healthify/fake_idp/pull/49