🙈 Add Gemfile.lock to gitignore

healthify / fake_idp

Fake IdP service for testing SAML

https://rubygems.org/gems/fake_idp

MIT License

15 stars 8 forks source link

🙈 Add Gemfile.lock to gitignore #59

Closed tylerwillingham closed 2 years ago

tylerwillingham commented 2 years ago

When reconciling dependencies in a project setting this lockfile is already ignored. When developers are working on and contributing to fake_idp, the specific dependency lock shouldn't matter - only the version constraints set in the gemspec.

Ignoring the lockfile and allowing developers to use different dependencies within the gemspec constraints better simulates the gem's use in the wild and might enable catching dependency issues sooner

tylerwillingham commented 2 years ago

This should also resolve the dependabot PRs

ernestns commented 2 years ago

@tylerwillingham when you have a moment, could you enable "Allow edits by maintainers" 🙏

tylerwillingham commented 2 years ago

@ernestns @RodCardenas done 👍

RodCardenas commented 2 years ago

Addressed in https://github.com/healthify/fake_idp/pull/64