healthify / guides

Guides for Coding Like a Healthifyte.
1 stars 0 forks source link

Use `qa/` prefix instead of `stage-` #10

Closed amar47shah closed 8 years ago

amar47shah commented 8 years ago

Also:

Reasons for qa/ naming convention:

We currently use branches with slash (/) delimiters. This means that our branches often look like this: f/my-feature.

Given a release branch f/my-feature, it's awkward to apply the stage- prefix: stage-f/my-feature, since this represents a "directory" relationship in the git filesystem, where stage-f is the directory.

Furthermore, staging is the name of our staging app git remote, which means that we cannot use staging/ as a prefix instead of stage-. Using stage/ might also cause confusion.

Therefore, to accommodate the slash delimiters most gracefully, and avoid confusion with the staging/ prefix of branches that live on the staging remote, this change proposes qa/ as the convention:

release branch: f/my-feature qa branch: qa/f/my-feature

KrishnaKulkarni commented 8 years ago

LGTM

switzersc commented 8 years ago

Ditto!

amar47shah commented 8 years ago

Awesome! thanks @switzersc @KrishnaKulkarni.

Merging now.