search

healthjoy / async-firebase

The lightweight asynchronous client that makes interaction with Firebase Cloud Messaging oversimplified.
MIT License
37 stars 14 forks source link

support python 3.12 #64

Closed TomerBin closed 1 year ago

akalex commented 1 year ago

I believe you have to use actions/setup-python@v4 to enable Python 3.12 support.

akalex commented 1 year ago

Okay, let's merge this one, and then I will fix CI/CD to avoid bothering you with that stuff. @TomerBin, Are you good with that?

hxtomer commented 1 year ago

Okay, let's merge this one, and then I will fix CI/CD to avoid bothering you with that stuff. @TomerBin, Are you good with that?

I've added allow-prereleases: true to the CI, maybe it'll work? I prefer to let the unit test run in the CI since i haven't run them locally.

akalex commented 1 year ago

Okay, let's merge this one, and then I will fix CI/CD to avoid bothering you with that stuff. @TomerBin, Are you good with that?

I've added allow-prereleases: true to the CI, maybe it'll work? I prefer to let the unit test run in the CI since i haven't run them locally.

Okay, that sounds reasonable.

TomerBin commented 1 year ago

@akalex Is it possible to grant me permissions to run the 3.12 action so I can test it effectively? Thank you

akalex commented 1 year ago

@akalex Is it possible to grant me permissions to run the 3.12 action so I can test it effectively? Thank you

Hey @TomerBin, sorry for the delay. I adjusted the configuration. You should now be able to Run GitHub actions.

TomerBin commented 1 year ago

Thanks. It's ready for merge :)