[Question] Limits has no effect?

healthjoy / async-firebase

The lightweight asynchronous client that makes interaction with Firebase Cloud Messaging oversimplified.

MIT License

37 stars 14 forks source link

[Question] Limits has no effect? #66

Closed svidchenkov-a closed 8 months ago

svidchenkov-a commented 8 months ago

I probably get it wrong, but it looks like Limits for client have no effect because we create a new httpx.AsyncClient with each AsyncClientBase.send_request call. I want to limit number of connections to FCM by limiting the number of connections in httpx connection pool, but appereantly for this to work we need to reuse httpx.AsyncClient beetween send_request calls

btw. @akalex thank you for your great work.

akalex commented 8 months ago

Hi @svidchenkov-a, Thanks for submitting a question. You are correct; in the current implementation, Limits have no effect. Let me fix that.