healthlocker / oxleas-adhd

https://focus.headscapegreenwich.co.uk/
8 stars 0 forks source link

Deploying master to staging #297

Closed RobStallion closed 6 years ago

RobStallion commented 6 years ago

Currently getting the following error when running the command mix edeliver build release.

==> Failed to build release:

    Undefined applications: [xmerl]

A remote command failed on:

  username@ip_address

Output of the command is shown above and the command executed
on that host is printed below for debugging purposes:
RobStallion commented 6 years ago

Have tried looking at the mix.exs file in the healthlocker app as I thought that this may be what was causing this issue. I have tried replicating earlier versions of the file before commits were merged but have been having the same issue.

Next step

Going to try and deploy earlier versions of master and see if they work. If they do then I will move on to the next version until I can pinpoint which merge may have caused this issue.

RobStallion commented 6 years ago

Thought that the issue may have to do with the mix.lock file. I deleted the one I had, ran the command mix deps.clean --all and then ran mix deps.get.

Once the file had been created, I branched off of master and created the deployment_bug branch. I committed the changes and pushed this branch. I then ran the command mix edeliver build release --branch=deployment_bug to try and build this branch but I am having the same issue

RobStallion commented 6 years ago

I checked out a branch from an older point in masters history (this point). Called the branch testing_deploy and ran the command mix edeliver build release --branch=deployment_bug. The build worked as expected.

This leads me to believe that the new code is causing this issue so going to continue going through the merges into master after this point to try and see if I can find the issue

RobStallion commented 6 years ago

This pr seems to be what is causing the issue when we run mix edeliver build release as it works up until this point.

It looks like the issue could be to do with phoenix_html_sanitizer. The reason for thinking this is that has phoenix_html_sanitizer has a dependancy called mochiweb which in turn looks like it has a dependency call xmerl. xmerl is the undefined application listed under failed to build release in the initial error comment at the top of this issue.

RobStallion commented 6 years ago

Have not been able to solve this bug yet. Have opened a stack overflow question here and have tried the answers that were posted but with no luck.

Going to remove the code that we think is causing this issue for the time being as we do not want to spend too much time on this.

The issue this relates to is #238. We will look into an alternate solution for this providing all goes well with the higher priority issues above this.

RobStallion commented 6 years ago

Removed phoenix_html_sanitizer from the application and have been able to build the branch with mix edeliver build release --branch=remove_sanitizer.

However now we are able to add divs etc in when on an input filed... image

Closing this issue and going to work on #238