search

healthlocker / oxleas-adhd

https://focus.headscapegreenwich.co.uk/
8 stars 0 forks source link

Teacher menu #318

Closed RobStallion closed 6 years ago

RobStallion commented 6 years ago

Update clinicians view of teachers and service users when in caseload #316

RobStallion commented 6 years ago

Have had an issue trying to test the files in apps/healthlocker/web/controllers/oxleas_adhd/caseload/*. The tests for the files in there do not appear to be running. I have asked a question on SO here

@nelsonic this code appears to be working when run locally but, so far, I have been unable to add tests for the new actions.

nelsonic commented 6 years ago

@RobStallion the code & tests in this PR look good. 👍 I've up-voted your StackOverflow question. (hope to get a reply ...) ⏳ Will hold off merging for a bit so "Dogbert" has time to answer. 😉

RobStallion commented 6 years ago

@nelsonic Any update on the PR? No pressure. I can deploy everything before this point if you do not want to merge at this point 👍

nelsonic commented 6 years ago

Hi @RobStallion, it's not a case of not wanting to merge it. Did you see the reply on your StackOverflow question? Worth leaving a comment on it if it is/not helpful. 😉

RobStallion commented 6 years ago

@nelsonic I just spotted the error. This is sort of how I felt at the time 😐+ 😄+ 😭. Have updated the tests 👍. Cannot believe that that was the error. This has been in the code since 10/5/17 🙈