search

healthonnet / hon-lucene-synonyms

Solr query parser plugin that performs proper query-time synonym expansion.
http://nolanlawson.com/2012/10/31/better-synonym-handling-in-solr
150 stars 67 forks source link

Update for Solr 5.3.1 #52

Closed joekiller closed 8 years ago

joekiller commented 8 years ago

I updated the python tests to work with Solr 5.x, which includes nuances in 5.0 -> 5.2.1 and another change in behavior at 5.3.1.

Issue #51 is outstanding and there is a test in java that is currently ignored.

I recreated the failing python test in java and made it passing and made the failing part an ignored test for now.

avlukanin commented 8 years ago

Thank you! However, it's not a good idea to format strings, change tabs to spaces, etc., where you don't really change the code itself. It's hard to understand, what was really changed in 26 files. Maybe it's better to create a patch and a new clean branch with only the code changes?

joekiller commented 8 years ago

Yeah I'll clean it up On Dec 12, 2015 10:18 AM, "Artem Lukanin" notifications@github.com wrote:

Thank you! However, it's not a good idea to format strings, change tabs to spaces, etc., where you don't really change the code itself. It's hard to understand, what was really changed in 26 files. Maybe it's better to create a patch and a new clean branch with only the code changes?

— Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/pull/52#issuecomment-164160722 .

nolanlawson commented 8 years ago

So this is an enormous change and probably much-needed to get up-to-date with the latest Solr. I also agree with @avlukanin about fixing the whitespace issues.

This is also probably a good time to ask: does it make sense anymore to keep supporting old Solr versions? Previously I had a very ambitious setup where we maintain multiple branches to port fixes to various versions of Solr, but I wonder how much value that's really adding, or if everybody in the community has already moved on to latest Solr.

I don't use Solr myself anymore, so can anybody advise? My instinct is to just drop support for old versions once this gets merged.

avlukanin commented 8 years ago

I think tagging is enough. So if you want a version for an older version of Solr like me, just checkout the needed tag and build the jar yourself.