search

healthonnet / hon-lucene-synonyms

Solr query parser plugin that performs proper query-time synonym expansion.
http://nolanlawson.com/2012/10/31/better-synonym-handling-in-solr
150 stars 67 forks source link

Distribute on maven? #59

Closed joekiller closed 8 years ago

joekiller commented 8 years ago

Any reason not to push releases to maven? We could configure travis-ci to push on tagged builds to make releases easier.

nolanlawson commented 8 years ago

I'd be happy to publish it on Maven! TBH at the time I wrote this library, I just wasn't very well-versed in how Maven worked. Also I kinda hoped eventually Solr would include it directly in core, but that seems less and less likely with each passing year.

I admit my time right now is pretty limited, so I probably will not publish it on Maven myself. But if anyone else would like to go through the effort to do so, I would happily endorse it. 👍

nolanlawson commented 8 years ago

Hey, so I was looking into rebuilding this and publishing a new version (just hosting the JAR somewhere for now), but I'm not sure: is Solr 6 a breaking change? If so, I'd prefer we release 3.0.0 instead of 2.0.1, just to make it clear that the changes are breaking.

joekiller commented 8 years ago

I don't think Solr 6 is a breaking change. There were some deprecated methods that we were using so I updated those. Basically going forward everything is Immutable so if you want a new query you use the builders instead of modifiers on am existing query. They did this with explanation in 5.2 I believe. On Apr 15, 2016 11:01 PM, "Nolan Lawson" notifications@github.com wrote:

Hey, so I was looking into rebuilding this and publishing a new version (just hosting the JAR somewhere for now), but I'm not sure: is Solr 6 a breaking change? If so, I'd prefer we release 3.0.0 instead of 2.0.1, just to make it clear that the changes are breaking.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/issues/59#issuecomment-210723867

joekiller commented 8 years ago

Also I can work on a PR that can push to maven tagged builds so our maintenance focuses on the code, not ops and rollout etc On Apr 16, 2016 9:06 AM, "Joseph Lawson" joe@joekiller.com wrote:

I don't think Solr 6 is a breaking change. There were some deprecated methods that we were using so I updated those. Basically going forward everything is Immutable so if you want a new query you use the builders instead of modifiers on am existing query. They did this with explanation in 5.2 I believe. On Apr 15, 2016 11:01 PM, "Nolan Lawson" notifications@github.com wrote:

Hey, so I was looking into rebuilding this and publishing a new version (just hosting the JAR somewhere for now), but I'm not sure: is Solr 6 a breaking change? If so, I'd prefer we release 3.0.0 instead of 2.0.1, just to make it clear that the changes are breaking.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/issues/59#issuecomment-210723867

joekiller commented 8 years ago

Yeah reviewing the code, only the test requires Solr 6 method changes between 5.5 and 6.0 so it should be okay. On Apr 16, 2016 9:07 AM, "Joseph Lawson" joe@joekiller.com wrote:

Also I can work on a PR that can push to maven tagged builds so our maintenance focuses on the code, not ops and rollout etc On Apr 16, 2016 9:06 AM, "Joseph Lawson" joe@joekiller.com wrote:

I don't think Solr 6 is a breaking change. There were some deprecated methods that we were using so I updated those. Basically going forward everything is Immutable so if you want a new query you use the builders instead of modifiers on am existing query. They did this with explanation in 5.2 I believe. On Apr 15, 2016 11:01 PM, "Nolan Lawson" notifications@github.com wrote:

Hey, so I was looking into rebuilding this and publishing a new version (just hosting the JAR somewhere for now), but I'm not sure: is Solr 6 a breaking change? If so, I'd prefer we release 3.0.0 instead of 2.0.1, just to make it clear that the changes are breaking.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/issues/59#issuecomment-210723867

nolanlawson commented 8 years ago

Ah okay, cool! So do you want to make 5.0.1 our first Maven release? Also I'm perfectly happy for you to publish it under your Sonatype/Maven account if you like. And I agree it's better to roll out stuff automatically (although let's keep old releases around in the README for folks still on old versions of Solr).

joekiller commented 8 years ago

Okay I'm bumping our version to 5.0.1 and pushing to maven. Will work on the CI part too.

nolanlawson commented 8 years ago

That's awesome, thanks a ton!!

joekiller commented 8 years ago

Moving forward. Here is the Jira ticket for sonatype: https://issues.sonatype.org/browse/OSSRH-21917

joekiller commented 8 years ago

Shoulda done a branch but we are published: http://search.maven.org/#search%7Cga%7C1%7Chon-lucene-synonyms

nolanlawson commented 8 years ago

Woot! Thank you!!

nolanlawson commented 8 years ago

Should we add instructions to the README so people can find them? Also feel free to add yourself to the maintainers list, since clearly I've been less-than-active recently. 😅

joekiller commented 8 years ago

Yurp. Perhaps we can make another issue to deploy from CI based on tags. On Apr 23, 2016 3:41 PM, "Nolan Lawson" notifications@github.com wrote:

Should we add instructions to the README so people can find them? Also feel free to add yourself to the maintainers list, since clearly I've been less-than-active recently. 😅

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/issues/59#issuecomment-213817311