Closed joekiller closed 8 years ago
Sorry for not reviewing this sooner; I was taking a Github vacation. Anyway this change looks good; the only odd thing IMO is checking in the .iml
file and explicitly mentioning IntelliJ integrations (my bad, I thought those changes were added to the README, not the .gitignore! looks good).
Anyway thanks for working to maintain this library in my absence; I've been super swamped because I have a bunch of other projects consuming my attention. Glad to see that other folks are keeping up with it! 😃
I agree the .iml
file is somewhat peripheral but it is pretty standard to
include it for project maintenance. It really sucks to run git clean -fd
for a clean project and lose your project settings.
On Apr 15, 2016 10:09 PM, "Nolan Lawson" notifications@github.com wrote:
Sorry for not reviewing this sooner; I was taking a Github vacation. Anyway this change looks good; the only odd thing IMO is checking in the .iml file and explicitly mentioning IntelliJ integrations.
Anyway thanks for working to maintain this library in my absence; I've been super swamped because I have a bunch of other projects consuming my attention. Glad to see that other folks are keeping up with it! 😃
— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/healthonnet/hon-lucene-synonyms/pull/61#issuecomment-210713902
This ports all the tests to Java.