healthyregions / SDOHPlace

Landing page and data discovery application for SDOH Place Project.
https://sdohplace.org
GNU General Public License v3.0
1 stars 1 forks source link

fix: refactored lib folder patterns surrounding posts + showcases #320

Closed bodom0015 closed 1 month ago

bodom0015 commented 1 month ago

Problem

There is quite a bit of copy-pasted code between the Posts + Showcases

We would like a better pattern for adding new categories to avoid copy-pasting as much in the future

Redo of #312

Fixes #302

Approach

How to Test

  1. Navigate to the list of "Project News" (PostList / PostItem): http://localhost:3000/news
  2. Choose an article (Layout -> PostLayout): http://localhost:3000/news/finding-healthy-food-connecticut
    • You should see no changes compared to production: https://sdohplace.org/news/finding-healthy-food-connecticut
    • NOTE: Images appear differently here, but these are not style changes - production appears to use different screenshot paths than dev
    • NOTE: Copyright symbol (at the bottom) has moved to the left a few pixels - I could not track down why, but this is barely noticeable
  3. Navigate to the list of "Fellow Showcases" (ShowcaseList / ShowcaseItem): http://localhost:3000/showcase
    • You should see no changes compared to production: https://sdohplace.org/showcase
    • NOTE: Images appear differently here, but these are not style changes - production appears to use different screenshot paths than dev
  4. Choose a showcase (Layout -> ShowcaseLayout): http://localhost:3000/showcase/windham-willmantic-conn-food-access-map
    • You should see no changes compared to production: https://sdohplace.org/showcase/windham-willmantic-conn-food-access-map
    • NOTE: Images appear differently here, but these are not style changes - production appears to use different screenshot paths than dev
    • NOTE: Copyright symbol (at the bottom) has moved to the left a few pixels - I could not track down why, but this is barely noticeable
netlify[bot] commented 1 month ago

Deploy Preview for cheerful-treacle-913a24 ready!

Name Link
Latest commit 80c958f360f6014591950c99f69f15a83d153345
Latest deploy log https://app.netlify.com/sites/cheerful-treacle-913a24/deploys/670494fb7f34080008ba78d8
Deploy Preview https://deploy-preview-320--cheerful-treacle-913a24.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodom0015 commented 1 month ago

I'm noticing that the font-size of the page header has changed somewhere... checking to see if I may have lost a bit of needed CSS along the way 🤔

bodom0015 commented 1 month ago

@mradamcox I think I've fixed all the styling discrepancies here :+1: sorry for the additional delay on this - I completely agree that we don't want any styling changes here as a part of this merge

Regarding the title, it looks like this is set incorrectly in config.json (contains "News"). Should I go ahead and correct that here? I don't think this is a regression if the bug currently exists on the production site, but maybe I'm missing some context?