healthyregions / SDOHPlace

Landing page and data discovery application for SDOH Place Project.
https://sdohplace.org
GNU General Public License v3.0
1 stars 1 forks source link

enable mul-ti selection of the theme filter #370

Closed pengyin-shan closed 2 weeks ago

pengyin-shan commented 2 weeks ago

This PR addresses #363. It enbles multi-selection for the themes filter.

How to Test

  1. Navigate to the search page and open the filter panel.

  2. Select the "Demographic" theme filter, then add the "Employment" filter. You should see the result list length increase due to the additional filter:

    Screenshot 2024-11-11 at 12 46 17 PM
  3. Open a result detail, and the corresponding theme icon should be highlighted:

    Screenshot 2024-11-11 at 12 45 31 PM
  4. Experiment with the filters to ensure the list updates as expected.

netlify[bot] commented 2 weeks ago

Deploy Preview for cheerful-treacle-913a24 ready!

Name Link
Latest commit df05f6628d1e31d297c681cc81beca34741f4e8a
Latest deploy log https://app.netlify.com/sites/cheerful-treacle-913a24/deploys/6733abc929b84f0008cf2bdd
Deploy Preview https://deploy-preview-370--cheerful-treacle-913a24.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pengyin-shan commented 2 weeks ago

Great, works as expected. Only thing we need is change the enabled color on border, icon, and text to french violet.

Did you mean to change the color to French violet after the icon is selected?

mradamcox commented 2 weeks ago

| Did you mean to change the color to French violet after the icon is selected?

Yes, when a filter is enabled change the colors to French violet. For the default colors, leave as is.

pengyin-shan commented 2 weeks ago

| Did you mean to change the color to French violet after the icon is selected?

Yes, when a filter is enabled change the colors to French violet. For the default colors, leave as is.

I updated the code to change the color when a theme is selected: Screenshot 2024-11-12 at 1 26 17 PM

mradamcox commented 2 weeks ago

Looks great. I'll merge this now. Thanks!