search

heap / react-native-heap

A React Native integration for Heap
MIT License
82 stars 36 forks source link

[HEAP-28313] implement getSessionId #313

Closed radiofreejohn closed 2 years ago

radiofreejohn commented 2 years ago

Heap Customer Support

Thanks for using Heap's React Native SDK! If you're having any issues, please reach out to customer support at support@heap.io. For the best service, include "React Native" in the subject and your app id or customer email address in the body. Also, feel free to file a github issue or open a PR! If you do so, be sure to include a link in your request to customer support. Our engineering team checks for new PRs and github issues and tries to respond as soon as possible.

Description

What does this PR add/fix/change? adds getSessionId method to return the current session id.

Is there anything reviewers should pay special attention to? tests - they only partially ran locally but the mock tests seemed fine. Also this is mostly a copy and paste of getUserId but the difference with getSessionId is that it can return null if called before initialization, which differs and I may have done something wrong there with types or the promise.

Are there any breaking changes? shouldn't be

Test Plan

How were these changes tested? mocked tests in jest

Were additional test cases added? yes Was there manual testing? no

Checklist