heap / react-native-heap

A React Native integration for Heap
MIT License
82 stars 36 forks source link

Update @expo/config-plugins for compatibility with expo-cli v6 #328

Open mikehazell opened 2 years ago

mikehazell commented 2 years ago

Running expo doctor with expo-cli version 6 produces the following.

[stderr] [02:18:30] Expected package @expo/config-plugins@^5.0.0
[stderr] [02:18:30] Found invalid:
[stderr] [02:18:30]   @expo/config-plugins@4.1.5
[stderr] [02:18:30]   (for more info, run: npm why @expo/config-plugins)

npm why @expo/config-plugins reveals this package as the cause.

@expo/config-plugins@4.1.5
node_modules/@heap/react-native-heap/node_modules/@expo/config-plugins
  @expo/config-plugins@"^4.1.5" from @heap/react-native-heap@0.21.0
  node_modules/@heap/react-native-heap
    @heap/react-native-heap@"^0.21.0" from the root project
eightyfive commented 1 year ago

Maybe also add "@expo/config-plugins": "^4" as a peerDependency instead of a hard dependency ?

But more importantly does @heap/react-native-heap works with latest "@expo/config-plugins": "^5" ? 😨