heap / react-native-heap

A React Native integration for Heap
MIT License
82 stars 36 forks source link

chore: fix Log.w message that was causing issue with android builds #335

Closed TheRogue76 closed 2 years ago

TheRogue76 commented 2 years ago

Heap Customer Support

Thanks for using Heap's React Native SDK! If you're having any issues, please reach out to customer support at support@heap.io. For the best service, include "React Native" in the subject and your app id or customer email address in the body. Also, feel free to file a github issue or open a PR! If you do so, be sure to include a link in your request to customer support. Our engineering team checks for new PRs and github issues and tries to respond as soon as possible.

Description

Small PR that fixes the Log warning that was added in previous version. Log.w needs a tag and a message string. Not passing the method cause the app not to build on Android Also the integrations tests' imports for the App component was setup incorrectly. metadataPropUtil.ts under js/util also had the wrong import (Please feel free to let me know if i have the configs wrong. I can revert the last changes, as the target of this PR was only to fix the warning issue on Android)

Test Plan

Same tests as it already had. Simply tested it on our current product to make sure it builds now and ran the repo's tests

Checklist

bnickel commented 2 years ago

This has been fixed in #349 and will be released today.