heap / react-native-heap

A React Native integration for Heap
MIT License
82 stars 36 forks source link

ios achieve failed - App not contain bitcode #343

Closed elirangoshen closed 2 years ago

elirangoshen commented 2 years ago

Hi, When Im achieve my app, I'm getting that error on Heap: "/Heap/Heap.framework/Heap does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target."

I can disable my bitcode in xcode but as it will affect my app I wonder if you aware of its and intend to use bitcode for heap ? I also didn't see anything in documentation

heap version: 0.22.0 react-native version: 0.69.4

jerryhjones commented 2 years ago

Hey @elirangoshen thanks for dropping a note.

As of Xcode 14, Apple has deprecated Bitcode, and it is stripped before submitting to the app store.

For this reason, we recommend disabling bitcode for your app - as there is no benefit to retaining it. I will ask our team to update our docs to make this clearer.

More info here: https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations https://arbyswift.com/why-does-xcode-14-deprecate-bitcode