heap / react-native-heap

A React Native integration for Heap
MIT License
82 stars 36 forks source link

fix: added missing parameter to Log.w method in Map case #348

Closed juniorklawa closed 2 years ago

juniorklawa commented 2 years ago

Heap Customer Support

Thanks for using Heap's React Native SDK! If you're having any issues, please reach out to customer support at support@heap.io. For the best service, include "React Native" in the subject and your app id or customer email address in the body. Also, feel free to file a github issue or open a PR! If you do so, be sure to include a link in your request to customer support. Our engineering team checks for new PRs and github issues and tries to respond as soon as possible.

Description

What does this PR add/fix/change? Error when building Android due to missing parameter in Log.w method @heap/react-native-heap/android/src/main/java/com/heapanalytics/reactnative/RNHeapLibraryModule.java:86: error: no suitable method found for w(String)

Is there anything reviewers should pay special attention to? N/A Are there any breaking changes? No

Test Plan

How were these changes tested? Installing and using the library Were additional test cases added? No Was there manual testing? Yes

Checklist

Fixes #334 and #347

bnickel commented 2 years ago

This has been fixed in #349 and will be released today.