And the app contains a useEffect or similar, which caused App to re-evaluate, the entire contents of HeapNavigationContainer will be considered new and will be recreated, sending the app back to start.
The general fix is to move Heap.withHeapNavigationWrapper out of a function but this has come up enough that a code fix is warranted.
This simply caches the output of withReactNavigationAutotrack on the wrapped component so it can be retrieved the next time it is called.
Test Plan
Unit tests were added and executed. This behavior was vetted in a test app.
It would be possible to write an integration test on this, if someone wants to.
Checklist
[x] Detox tests pass
[x] If this is a bugfix/feature, the changelog has been updated
Description
If
Heap.withHeapNavigationWrapper
is called multiple times, it currently returns a new HOC each time. This means if the app looks like this:And the app contains a
useEffect
or similar, which causedApp
to re-evaluate, the entire contents ofHeapNavigationContainer
will be considered new and will be recreated, sending the app back to start.The general fix is to move
Heap.withHeapNavigationWrapper
out of a function but this has come up enough that a code fix is warranted.This simply caches the output of
withReactNavigationAutotrack
on the wrapped component so it can be retrieved the next time it is called.Test Plan
Unit tests were added and executed. This behavior was vetted in a test app.
It would be possible to write an integration test on this, if someone wants to.
Checklist