heapsource / active_model_otp

Adds methods to set and authenticate against one time passwords (Two-Factor Authentication). Inspired in AM::SecurePassword
MIT License
783 stars 81 forks source link

Update rotp → 6.3.0 (unknown) #118

Closed depfu[bot] closed 8 months ago

depfu[bot] commented 1 year ago

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rotp (~> 6.2.0 → ~> 6.3.0) · Repo · Changelog

Release Notes

6.3.0

6.3.0 (2023-08-30)

Features

  • Allow for non-standard provisioning URI params, eg. image/icon (#91) (45d8aac)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
Skulli commented 8 months ago

https://github.com/mdp/rotp/security/advisories/GHSA-x2h8-qmj4-g62f

chrisdebruin commented 8 months ago

Can this be merged? There is a CVE-2024-28862 in rotp 6.2 dependency. Thanks

neongrau commented 8 months ago

pretty please someone do a @​depfu merge

arinchoi03 commented 8 months ago

please merge this soon, thank you! maybe @robertomiranda @pedrofurtado ?

ash-rc commented 8 months ago

Adding to this, this needs to be updated ASAP @robertomiranda @guilleiguaran @bithavoc

chrisdebruin commented 8 months ago

Thanks a lot @guilleiguaran

jeffbax commented 8 months ago

Is there going to be a new release of active_model_otp itself with the dependency change?

chriskoelle commented 7 months ago

@guilleiguaran any timeline on a release for this?

bithavoc commented 7 months ago

@guilleiguaran rubygems

nathansamson commented 7 months ago

Why not make the dependency less strict '~> 6.3' probably works as well (assuming rotp follows semver correctly) and gives users of this gem easier upgrade paths

chriskoelle commented 7 months ago

@guilleiguaran @robertomiranda @bithavoc sorry to be a bother but could somebody please push a rubygems release for this? 🙏 CVE-2024-28862 was published a month ago.

robertomiranda commented 7 months ago

released https://rubygems.org/gems/active_model_otp/versions/2.3.4

arinchoi03 commented 7 months ago

yay thank you so much!

jeffbax commented 7 months ago

thank you!