heapsource / active_model_otp

Adds methods to set and authenticate against one time passwords (Two-Factor Authentication). Inspired in AM::SecurePassword
MIT License
773 stars 81 forks source link

Fix SystemStackError with ActiveRecord #27

Closed garethrees closed 8 years ago

garethrees commented 9 years ago

Fixes #26

If you use the default otp_counter column name, InstanceMethodsOnActivation#otp_counter calls otp_counter resulting in a stack overflow.

garethrees commented 9 years ago

Cleared up some Hound warnings – remaining ones are just following existing conventions.

garethrees commented 9 years ago

http://stackoverflow.com/questions/7754100/cannot-install-sqlite3-with-jruby https://www.tiredpixel.com/2014/01/05/curses-conditional-ruby-gem-installation-within-a-gemspec/ https://en.wikibooks.org/wiki/Ruby_Programming/RubyGems#How_to_install_different_versions_of_gems_depending_on_which_version_of_ruby_the_installee_is_using

garethrees commented 9 years ago

Anything I can do to help get this merged? Cheers.

robertomiranda commented 9 years ago

@garethrees sorry for the delay, I'm going to take a look today

garethrees commented 9 years ago

@robertomiranda thanks, much appreciated! Feel free to get in touch if there's anything you need to clarify :) :beers: