search

heapsource / active_model_otp

Adds methods to set and authenticate against one time passwords (Two-Factor Authentication). Inspired in AM::SecurePassword
MIT License
773 stars 81 forks source link

Changes to be compatible with ROTP `4.0.2` #45

Closed subinwalter closed 6 years ago

subinwalter commented 6 years ago

Fixes https://github.com/heapsource/active_model_otp/issues/44

subinwalter commented 5 years ago

This was done to make active_model_otp compatible with ROTP > 4.0.0 . But it didn't do it in a backward compatible way. Now there are two options either make active_model_otp backward compatible with ROTP < 4.0.0 or change the dependency of active_model_otp gem to ~> 4.0.0, which option to choose is up to the maintainers of this gem

guilleiguaran commented 5 years ago

@subinwalter I haven't chance to use this gem during the last years so I can't maintain it properly so I've added you as collaborator.

Please just add an note in the README if any future/current version is incompatible with previous versions so users can lock the gem to a proper version 🙏

subinwalter commented 5 years ago

@guilleiguaran opened PR