search

heapsource / active_model_otp

Adds methods to set and authenticate against one time passwords (Two-Factor Authentication). Inspired in AM::SecurePassword
MIT License
773 stars 81 forks source link

Add interval option #72

Closed rusikf closed 3 years ago

rusikf commented 4 years ago

Hi ! 1) ROTP gem supports interval option => It will be awesome to support it in this gem too :nerd_face: 2) There is a test error

/home/rusikf/.rvm/gems/ruby-2.6.4/gems/bundler-2.1.4/lib/bundler/rubygems_integration.rb:346:in `block (2 levels) in replace_gem': Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-1.3.13. Make s
ure all dependencies are added to Gemfile. (LoadError)

The reason - in rails_6.0.gemfile dependency is 1.4 but in gemspec we have 1.3

gemfiles/rails_6.0.gemfile:gem "sqlite3", "~> 1.4" That's why I upgraded sqlite to 1.4

pedrofurtado commented 3 years ago

Hey @rusikf ! 👋

Thanks for your contribution 🎉

Could you please rebase PR with the main branch, and fix the warnings of CI? After that, we will be able to review it together (you, me, @robertomiranda and other team member) 🍻

pedrofurtado commented 3 years ago

We can follow the progress of this feature here, including docs and so on: #87 🤝 🍻