search

heapsource / active_model_otp

Adds methods to set and authenticate against one time passwords (Two-Factor Authentication). Inspired in AM::SecurePassword
MIT License
773 stars 81 forks source link

Fix pr #72 #87

Closed matthewford closed 3 years ago

matthewford commented 3 years ago

Fixes the merge conflict in #72

matthewford commented 3 years ago

@pedrofurtado any ideas on how to get rails 4 not to load the XML gem?

pedrofurtado commented 3 years ago

Hi, @matthewford ! Sorry, but I did not understand the purpose/motivations of PR and this question about rails 4 + xml. Can you explain with more details, please? 🍻 🤝

You reused the source code of another open PR, is there any special reason for this?

Thanks a lot! 👍

matthewford commented 3 years ago

this pr is effectively the same but with a rebase, however might need to squash my commits due to faffing with getting the specs to pass on rails 4

pedrofurtado commented 3 years ago

We can follow the progress of this feature here, including docs and so on: https://github.com/heapsource/active_model_otp/pull/87 🤝 🍻