search

heapwolf / complete

Does your Node.js command line program have lots of arguments? Add custom tab completion!
165 stars 14 forks source link

complete adds .bash_profile on OSX when using .profile #4

Closed johnkpaul closed 12 years ago

johnkpaul commented 12 years ago

After npm installing a library that has complete as a dependency, suddenly my shell's default settings disappeared. After some digging, I figured out that it was because this library writes a .bash_profile file in user's home directory. When .bash_profile exists, OSX stops sourcing .profile. I think it would be better if this library could check to see if .bash_profile or .profile exists and use whichever one is available.

heapwolf commented 12 years ago

not your fault @chjj, I should have reviewed your code better =)

chjj commented 12 years ago

Bah, I am so bad at macs!

Marak commented 12 years ago

Should be merged and fixed now.

johnkpaul commented 12 years ago

Great. Thank you, @Marak @chjj and @hij1nx!