search

heapwolf / ldb

A C++ REPL / CLI for LevelDB
MIT License
201 stars 23 forks source link

use clib/leveldb as dependency? #32

Closed ralphtheninja closed 8 years ago

ralphtheninja commented 10 years ago

@jwerle Would it be easy to add clib/leveldb as a dependency instead of having the code checked in?

jwerle commented 10 years ago

It could but please know for now this installs leveldb as a system library however you could always modify the 'PREFIX' variable during a 'clib install leveldb' On May 18, 2014 12:14 PM, "ralphtheninja" notifications@github.com wrote:

@jwerle https://github.com/jwerle Would it be easy to add clib/leveldb as a dependency instead of having the code checked in?

— Reply to this email directly or view it on GitHubhttps://github.com/hij1nx/ldb/issues/32 .

ralphtheninja commented 10 years ago

That would be awesome.

heapwolf commented 10 years ago

bump

jwerle commented 10 years ago

@hij1nx so what do you think ? Do you mind having it installed at a system level or do you want it to live in deps/ ?

heapwolf commented 10 years ago

I'm trying to think of the benefits of having it locally, would anyone ever want to have multiple versions of leveldb installed at the system level?

ralphtheninja commented 10 years ago

It would also mean some refactoring on Makefile level, for example ldb and ldbcmp are identical when it comes to leveldb dependencies.

heapwolf commented 10 years ago

This seems like it should be fine. Anyone want to go for it?

ralphtheninja commented 10 years ago

Completely unrelated. @jwerle Do you have an email I can reach you at? You can give it to me on mail if you don't want to disclose it here. ralphtheninja@riseup.net Assuming you want to give it out at all obviously :)

jwerle commented 10 years ago

just emailed you

On Sat, May 24, 2014 at 2:07 PM, ralphtheninja notifications@github.comwrote:

Completely unrelated. @jwerle https://github.com/jwerle Do you have an email I can reach you at? You can give it to me on mail if you don't want to disclose it here. ralphtheninja@riseup.net

— Reply to this email directly or view it on GitHubhttps://github.com/hij1nx/ldb/issues/32#issuecomment-44094903 .