Major refactor - Githubissues

heapwolf / ldb

A C++ REPL / CLI for LevelDB

MIT License

201 stars 23 forks source link

Major refactor #33

Closed ralphtheninja closed 10 years ago

ralphtheninja commented 10 years ago

Added lib/repl.h to export one function
Moved includes to the .cc file they are needed for
Removed not needed includes
Removed a lot of ldb:: prefixing, ldb:: namespace is only needed for exported functions
Made a lot of functions static

I should be done now and can start hacking on new functionality.

heapwolf commented 10 years ago

I think the header file should keep the interface definitions because i want to add command-line options to reuse the functions; for instance, lev --ls.

For reuse, ldb.cc should also keep the defs and struct with its command aliases.

the linenoise loop should definitely be moved to repl.cc, but probably just this -- https://github.com/hij1nx/ldb/blob/master/ldb.cc#L71-L136

otherwise this looks good

ralphtheninja commented 10 years ago

Perhaps we can take a look at it today or tomorrow. Probably much easier :)

heapwolf commented 10 years ago

oh! are you in germany?? if so, email me!

ralphtheninja commented 10 years ago

Not yet. Will be there around 6-7pm or so.

ralphtheninja commented 10 years ago

Scrapping this PR. Creating new one later.