search

heapwolf / prompt-sync

a synchronous prompt for node.js
MIT License
218 stars 42 forks source link

v4 proposal #16

Closed davidmarkclements closed 8 years ago

davidmarkclements commented 8 years ago

first pass , as per #15

davidmarkclements commented 8 years ago

Along with API changes, there's quite a few fixes - also changed behaviour of value, so that it's essentially the default if no input is supplied

still todo

heapwolf commented 8 years ago

LGTM! Any steps to reproduce on deletes and inserts?

davidmarkclements commented 8 years ago

so run test.js and then try to backspace, also inserts work it's just the cursor that's not positioned correctly (because we write out whole strings)

also - I have the readme (and jsdocs) written, haven't pushed yet

On Sun, Feb 28, 2016 at 11:54 PM, paolo fragomeni notifications@github.com wrote:

LGTM! Any steps to reproduce on deletes and inserts?

— Reply to this email directly or view it on GitHub https://github.com/0x00A/prompt-sync/pull/16#issuecomment-189972578.

David Mark Clements Ltd is a company registered in Northern Ireland. Registered number: NI617728. Registered office: Unit 22a, Pennybridge Industrial Estate, Ballymena, Antrim, BT42 3HB

heapwolf commented 8 years ago

save and restore would probably work perfectly!

davidmarkclements commented 8 years ago

ok updated - did a commit amend and force push to keep commits shallow

@0x00A would you mind giving it a check over and publish if you're happy

time for :sleeping: for me :zzz:

davidmarkclements commented 8 years ago

oh hold on, wait one sec, need to publish history module

davidmarkclements commented 8 years ago

ok done, https://www.npmjs.com/package/prompt-sync-history

PR is ready for inspection

heapwolf commented 8 years ago

LGTM!