[Bug] Broadcasts are saved as messages in all logs

[students-gi]

For some reason, during this and the last few updates (from 19.3 onwards, I think?) broadcasted messages made by FList community mods have been saved in all open logs that I have, whether they be private messages or public channels. I've managed to mitigate this some by manually editing the logs and having F-Chat rewrite them, but more often than not they have to remain inside the logs, since they often go off when I'm away or asleep. For a look on how it appears from a passive account of mine:

If needed, I can give the log files as well, though I doubt they could explain what the fault would be.

[students-gi]

Commenting again just to say that the issue persists on the newest 1.23.3 version

[Alexaction]

This is also effecting me but I have to ask how you even edit your logs dude, I wanna take those two broadcasts out of some of my logs.

[students-gi]

Well, I can only "edit" them if the broadcast messages are at the end of the log file. I basically just delete the offending lines from my private logs (since in public channels they are often buried in a few minutes anyways) and rebuild them with the "fix corrupted logs" option. Unfortunately there's not really a way to delete them if they're already buried underneath other messages due to the weird time encoding they use.

If you want to do this yourself, seriously, make a copy of the initial logs. There is a good chance that deleting and fixing could actually bork the entire chat log, leaving you with a destroyed log history for that character.

[Alexaction]

Yeah I already don't like how the log storing works on f-chat, really wish it was like slimcat with it just being a .txt file. Anyway, I'll give a try later then, thanks for the heads up on the dangers tho.

[DemonPriestessSahala]

Ah, you're looking at the results of this commit: https://github.com/hearmeneigh/fchat-rising/commit/6b2d49f630cdfc1072b1e29ddcddb181517f18b5

Broadcasts became a separate type of exportable message in February (formerly event messages): export type Message = BcastMessage | EventMessage | ChatMessage;

export type Message = Conversation.EventMessage | Conversation.BcastMessage | {

const message = new BroadcastMessage(l('events.broadcast',[user]${data.character}[/user], content), char, time);

If you want to see how the log fixing process works, check out filesystem.ts.

[Alexaction]

Honestly I just want the option to save logs to txt files. Those weren't even corruptible when I used slimcat.

[Alexaction]

Once again it happens....

[DemonPriestessSahala]

As a recommendation (in response to the question on the version history "remove broadcasts from logs; maybe into a dialog? where do we store them tho? At least shouldn't orange-highlight all convos"), since these are now a different class of message, is there anything wrong with displaying and saving these only in the Console log, instead of the channel logs?