hearmeneigh / fchat-rising

A heavily modded F-Chat 3.0 client for F-List
https://hearmeneigh.github.io/fchat-rising/
MIT License
40 stars 19 forks source link

Fix [hr] in collapse title #276

Closed Abeehiltz closed 11 months ago

Abeehiltz commented 11 months ago

A lot of users add [hr] tags in their collapse title. While F-list records that it is a normal behaviour to not parse [hr] tags in collapse titles, a lot of people I interact with think don't want to use the app because of this "parsing issue".

A quick fix of mine has been to basically bypass in the parser when there is any [hr] tags in the parameter, and then replace the [hr] by


to show them.

hearmeneigh commented 11 months ago

@Abeehiltz Thanks! Would you mind sharing a quick example BBCode where the (unfixed) client breaks?

Abeehiltz commented 11 months ago

Sure! This is the BBCode that breaks the client:

[collapse=[hr]test[hr]]
This is a test content
[/collapse]

On the current version, it shows up like this: image

And with my fix: image

hearmeneigh commented 11 months ago

Will be part of 1.25.0