search

hearmeneigh / fchat-rising

A heavily modded F-Chat 3.0 client for F-List
https://hearmeneigh.github.io/fchat-rising/
MIT License
40 stars 17 forks source link

[Bug?] hr is not getting parsed from within header tags #300

Open temp-ail opened 9 months ago

temp-ail commented 9 months ago

Despite the claim within the comment of bbcode/standard.ts created at commit d072d4a made by @Abeehiltz, the [hr] BBCode tag isn't getting properly translated into a horizontal separator.

Display in F-List Display in F-Chat Rising

Abeehiltz commented 9 months ago

Hello @temp-ail

My fix was only when HR were parts of a collapse title, those ones appear to be outside a collapse title.

I double checked with an older version of the app without my fix (here 1.24.2) in case my code broke something, and the issue was already present.

image

the issue likely comes from the [header] parent tag like you mentioned. I unfortunately didn't touch this in my commit as my goal was only to fix collapses that were no longer collapsing due to hr tags often present and having a major impact on profile viewing.

(edit: yes, it is a "bug", I agree (even if f-list main devs would argue it is by design like this), but it doesn't have any link to my fix.)

temp-ail commented 9 months ago

Okay, sorry for pinging you then