hearmeneigh / fchat-rising

A heavily modded F-Chat 3.0 client for F-List
https://hearmeneigh.github.io/fchat-rising/
MIT License
40 stars 18 forks source link

Ability to change between New style / Windows Style Emojis #318

Closed Supervising0 closed 4 months ago

Supervising0 commented 9 months ago

The new style of the emojis is quite washed up and hard to see in statuses and general messages on a client - At least compared to their default Windows equivalents.

The ability to switch between the new style and Windows default would be appreciated.

1.26 Emojis image (1) Windows Emojis image

FatCatClient commented 9 months ago

I'm the one who added the new emoji (see #304) and even I kind of hate the way most of these look when they're small. Thought of using the TweMoji set instead, which are the same ones both Twitter and Discord use. But making a font out of them was a pain and I'm not to keen on forcing a whole JS library on someone else's project.

Honestly, I think a better idea than having a toggle for them is to just have the new font be the fallback for the system font, so that most emoji will look perfectly fine and the way people are probably used to seeing them, but anything that's missing can use the OpenEmoji font so they don't see boxes instead.

I already thought of making a PR for that a few days ago, but if even other people are complaining about it then they're probably right.

Supervising0 commented 9 months ago

I'm the one who added the new emoji (see #304) and even I kind of hate the way most of these look when they're small. Thought of using the TweMoji set instead, which are the same ones both Twitter and Discord use. But making a font out of them was a pain and I'm not to keen on forcing a whole JS library on someone else's project.

Honestly, I think a better idea than having a toggle for them is to just have the new font be the fallback for the system font, so that most emoji will look perfectly fine and the way people are probably used to seeing them, but anything that's missing can use the OpenEmoji font so they don't see boxes instead.

I already thought of making a PR for that a few days ago, but if even other people are complaining about it then they're probably right.

I agree that it is the best of both worlds. I'm pretty sure that the average pixel resolution on TweMoji's is a bit bigger than the Windows equivalent and they would just be out of place when combined with the usual font size - So it's time and effort saved in the end 😊

Also thanks for the fast response!

hearmeneigh commented 4 months ago

Fixed in 1.27. Thanks @FatCatClient!